Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant

[Stefan Richter]

> On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev
> <dmitri.vorobiev@xxxxxxxxx> wrote:
>> Paolo Ciarrocchi wrote:
>>>
>>> -static void fld_const(FPU_REG const *c, int adj, u_char tag)
>>> +static void fld_const(FPU_REG const * c, int adj, u_char tag)
>> ________________________________________^
>>
>> The above does not seem to me like a big improvement in code quality. A
>> false positive from checkpatch.pl?

It should obviously be

 static void fld_const(const FPU_REG *c, int adj, u_char tag)

FPU_REG is not an appropriate type name though.  Is "typedef struct
fpu__reg FPU_REG;" necessary at all?  (Removing it would create some
code churn all over x86/math-emu/ though. Maybe not desirable.)
-- 
Stefan Richter
-=====-==--- -==- =--=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/