Re: [PATCH] x86: let MPS support selectable

[Maciej W. Rozycki]

On Thu, 19 Jun 2008, Yinghai Lu wrote:

> @@ -233,6 +233,19 @@ config SMP
>  
>  	  If you don't know what to do here, say N.
>  
> +config X86_FIND_SMP_CONFIG
> +	def_bool y
> +	depends on X86_MPPARSE || X86_VOYAGER || X86_VISWS
> +	depends on X86_32
> +
> +config X86_MPPARSE
> +	def_bool y
> +	bool "Enable MPS table"
> +	depends on (X86_32 && (X86_LOCAL_APIC && !X86_VISWS)) || X86_64
> +	help
> +	  For old smp systems that do not have proper acpi support. Newer systems
> +	  (esp with 64bit cpus) with acpi support, MADT and DSDT will override it
> +
>  choice
>  	prompt "Subarchitecture Type"
>  	default X86_PC

 First of all you want to make sure at least one of ACPI and X86_MPPARSE
is enabled if X86_LOCAL_APIC or you risk a known-broken kernel
configuration, e.g. SMP which has no slightest chance to work.

 Personally I'd be happy to see CONFIG_ACPI_BOOT we used to have at one
point back just so that you can use ACPI tables to run an SMP system
without the need to pull all the power management stuff.  Useful if the MP
table is broken beyond recovery.  I am assuming it has been removed for a
reason though.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/