Re: [git pull] drm patches for 2.6.26-final

From: Dave Airlie
Date: Fri Jun 20 2008 - 06:19:19 EST



> >> Author: Johannes Weiner <hannes@xxxxxxxxxxxx>

I did report the author here ^^, I didn't see a reported by credit on the
original email.

and I suggested this was the patch, and I was wrong, and I've rewritten
it, and not I realise the drm ioctls are as ever a really big mess, the
driver ioctls on the kernel side don't have direction bits which is really
bad.

Dave.



> >> Date: Fri Jun 13 15:04:40 2008 +1000
> >>
> >> drm: use drms ioctl cmd not what we get passed from userspace.
> >>
> >> This enforces us to use the drm ioctl types so read/write works correctly and not believe
> >> what userspace tells us.
> >>
> >> It does this hopefully without breaking the drm api.
> >>
> >> Fixes bug from thread: BUG: unable to handle kernel NULL pointer dereference (drm_getunique)
> >>
> >> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
>
> Reported-by: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxxx>
>
> That was only a proposal, to which you did not reply at all [1] and just
> silently picked it (without the credits). Not very polite.
>
> Hannes
>
> [1] http://lkml.org/lkml/2008/6/5/250
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/