Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug duringMTU change

From: Séguier Régis
Date: Fri Jun 20 2008 - 06:24:21 EST


Francois Romieu a écrit :
Séguier Régis <rseguier@xxxxxxxxxxxxxx> :
I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/
[...]
Patch 0001 doesn't work,

if I don't make a mistake skb->len is not modified in skb_pad{,to}when the padding is applied. In this case, we need to attribute ETH_ZLEN to len.

Yes, that's what the driver did beforehand.

The updated serie is at the usual place. Does it perform better ?

Ok for the mtu change, no error messages, I try multiples mtu (1400,2000,4500,9000).

But if I generate a paquet with a size more than around 3825, the driver don't send it and no paquet is send after, work again after an interface down/up and until no paquet > 3825.

--
Régis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/