Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation

[Ingo Molnar]

* Alok Kataria <akataria@xxxxxxxxxx> wrote:

>  		loops_per_jiffy = preset_lpj;
> -		printk("Calibrating delay loop (skipped)... "
> -			"%lu.%02lu BogoMIPS preset\n",
> -			loops_per_jiffy/(500000/HZ),
> -			(loops_per_jiffy/(5000/HZ)) % 100);
> +		printk(KERN_DEBUG "Calibrating delay loop skipped, "
> +				"using preset value.. ");

i dont think the message should be eliminated from default logs via 
making it KERN_DEBUG - this message is a common pattern people watch out 
for and it does give an indication about various sorts of 
timing/performance trouble.

also, if you break a line like hat i'd suggest to do it like this:

> +		printk(KERN_DEBUG
> +		  "Calibrating delay loop skipped, using preset value.. ");

so that the string remains on a single line.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/