Re: [PATCH, RFC] fasync() BKL pushdown

[Jonathan Corbet]

On Fri, 20 Jun 2008 13:58:40 -0700
Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> only question is if this one is really needed:
> +	lock_kernel();
>  	tty = (struct tty_struct *)filp->private_data;
>  	if (tty_paranoia_check(tty, filp->f_path.dentry->d_inode,
> "tty_fasync"))
> -		return 0;
> +		goto out;
>  
>  	retval = fasync_helper(fd, filp, on, &tty->fasync);
>  	if (retval <= 0)
> 
> (given that it just calls the helper.. mostly and that Alan has been
> busy removing the BKL from the tty layer)

There's enough other stuff going on there, including manipulations of
the tty_struct, waitqueue_active() checks, etc., that I figured I should
really leave the BKL in there and let Alan figure it out.  I've learned
that it's best to tread with great care in that part of the kernel...

jon


Jonathan Corbet / LWN.net / corbet@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/