Re: [PATCH] Priority heap infrastructure enhancements

[Paul Menage]

On Wed, Jun 18, 2008 at 6:48 AM, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
>
> Some of the common code has been factored into heap_adjust() a.k.a heapify
> in data structures terminology.
>
> I am sending out this  patch indepedent of the memory controller changes as
> they deserve to be reviewed independently.
>
> One limitation of the current heap_insert() routine is that it does not
> insert an element which is greater than the root, when the heap slots
> are fully used. I'll work on and review that interface and find a suitable
> way to address that issue

How else would you want it to behave? If you have a fixed size heap
and it's full, then you have to drop the largest value. (Well, you
could in theory drop the smallest value, but there's no quick way to
find that.)

>
> Comments, Flames? Please do review closely!
>
> Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>

Looks fine.

Reviewed-by: Paul Menage <menage@xxxxxxxxxx>

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/