Re: LMSENSORS: 2.6.26-rc, enabling ACPI Termal Zone support costssensors

[Jean Delvare]

Hi Rui,

On Mon, 23 Jun 2008 09:44:42 +0800, Zhang Rui wrote:
> On Mon, 2008-06-23 at 05:58 +0800, Rene Herman wrote:
> > On 22-06-08 20:25, Rene Herman wrote:
> > 
> > > Another way to solve it _could_ be to just make up a device link if
> > > something generic is available so that sensors doesn't trip over it
> > > in the first place but I don't know if that's a good option. You
> > > might.
> > 
> > This also works for me and, if correct, is ofcourse better than the
> > CONFIG option. Wants a comment from the thermal_zone side (for which
> > Zhang Rui seems the correct CC?) though.
> Hi, Rene and Hans,
> 
> Thank you for your efforts on this issue and sorry for the late
> response, I did not check my email during the whole weekend.
> 
> About the hwmon ABI, after the device symbol link is created, are there
> any other ABIs required in the device node?

Not that I know of. The code currently in the kernel works just fine
with both lm-sensors SVN trunk (which will become 2.10.7 soon) and
3.0.2 as far as I can see.

> If no, this patch seems to work, although it might break if the first
> registered ACPI thermal zone device is unregistered, which ONLY happens
> theoretically.

If I remember correctly, there are more than one device in a given
thermal zone, so having a link pointing to one of them would create an
asymmetry. This basically means that nobody can use the device link in
question, so there's no point in creating it from a functional point of
view. If the goal is simply to solve the breakage that was reported by
Rene, the bug is in libsensors, so that' where it must be fixed (and
actually it already is.)

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/