Re: [PATCH] dabusb: use request_firmware()

From: Christoph Hellwig
Date: Mon Jun 23 2008 - 07:20:20 EST


> +config USB_DABUSB_FIRMWARE
> + bool "Include firmware images for DABUSB driver"
> + depends on USB_DABUSB
> + ---help---
> + Include the firmware for the DABUSB device in the kernel image.
> + Say 'N' and let it get loaded from userspace.

Sorry if I missed a discussion on it in the intial firmware threads, but
what is the point of all these FOO_FIRMWARE options? I think we should
include all firmware that we have a driver for if people want firmware
built-in and non if not.

That is instead of all these FOO_FIRMWARE options just have one
user-visible BUILTIN_FIRMWARE option. Also makes it much less likely
for mingo to accidentally build a kernel image that doesn't actually boot :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/