Re: [PATCH] x86: cleanup using max_low_pfn for 32 bit

From: Yinghai Lu
Date: Mon Jun 23 2008 - 16:28:10 EST


On Mon, Jun 23, 2008 at 1:22 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
>> x86: clean up using max_low_pfn on 32-bit
>
> this one needed the small fix below.
>
> Ingo
>
> ----------->
> commit 749cffb6c81f6637bbd054a4db246196eaa69ccc
> Author: Ingo Molnar <mingo@xxxxxxx>
> Date: Mon Jun 23 22:19:22 2008 +0200
>
> x86: build fix
>
> fix:
>
> arch/x86/kernel/setup_32.c:409: error: 'enable_local_apic' undeclared (first use in this function)
> arch/x86/kernel/setup_32.c:409: error: (Each undeclared identifier is reported only once
> arch/x86/kernel/setup_32.c:409: error: for each function it appears in.)
>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>
> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
> index b42f570..1e67037 100644
> --- a/arch/x86/kernel/setup_32.c
> +++ b/arch/x86/kernel/setup_32.c
> @@ -406,7 +406,9 @@ void __init setup_arch(char **cmdline_p)
> parse_early_param();
>
> if (acpi_mps_check()){
> +#ifdef CONFIG_X86_LOCAL_APIC
> enable_local_apic = -1;
> +#endif
> clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC);
> }

need to merge enable_local_apic (32bit) and disable_apic (64 bit).

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/