Re: [PATCH 05/11] sysfs: sysfs_chmod_file handle multiple superblocks

[Daniel Lezcano]

Tejun Heo wrote:
> Hello, guys.  Sorry about the long silence.  Recent releases of
> popular distros overwhelmed me with ata bugs.  They now seem to be
> under control (and hopefully stay that way for some time to come).
>
> On the previous iteration, I was hoping I could sort out sysfs
> interface problem before this patchset but given that this is a long
> overdue feature, I think we should get this thing working first.
>
> The first four patches looked good to me, so feel free to add
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
>
> Benjamin Thery Wrote:
> > sysfs: sysfs_chmod_file handle multiple superblocks
> >
> > Teach sysfs_chmod_file how to handle multiple sysfs
> > superblocks.
>
> I think it would be great if sysfs_chmod_file can do all-or-nothing
> instead of failing half way through but given the interface of
> notify_change(), it could be difficult to implement.  Any ideas?

Is it acceptable to queue the notifications in a list until we are in 
the loop and loop again to notify when exiting the first loop without 
error ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/