Re: [RFC][PATCH] ext3: don't read inode block if the buffer has awrite error

From: Linus Torvalds
Date: Mon Jun 23 2008 - 23:42:36 EST




On Tue, 24 Jun 2008, Nick Piggin wrote:
>
> What you want to do is not insane, but the way it is currently being
> done is. As I said, just clearing the uptodate bit might blow up your
> kernel pretty quickly from assertions in the vm. It should be going
> through the whole truncate or invalidate page machinery in order to
> do that.

Fair enough.

I would not mind, for example, leaving the uptodate bit, but removing it
from the radix tree or something like that (ie turning it into an
anonymous page for a page-cache page, just removing it from the
hash-queues for a buffer_head).

Of course, that could cause other problems (eg any VM assertions that
shared mappings only contain non-anon pages).

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/