Re: [PATCH] leds: make sure led->trigger is valid before callingtrigger->activate

[Richard Purdie]

On Wed, 2008-06-25 at 13:50 +0400, Dmitry Baryshkov wrote:
> On Tue, Jun 24, 2008 at 02:02:35PM -0700, Andrew Morton wrote:
> > 
> > The changelog tells us what the patch does, but it doesn't tell us
> > why it does it.
> > 
> > This matters.  For a start, there is no way in which I (at least)
> > am able to determine whether this change is needed in 2.6.26 nor
> > in 2.6.25.x.
> 
> I hope this is better. This isn't an 2.6.25.x material. And probably not
> an 2.6.26.
> 
> From 4ce3598c6ce5e6b529a05432b18996a99cc5bf0d Mon Sep 17 00:00:00 2001
> From: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> Date: Wed, 25 Jun 2008 13:48:07 +0400
> Subject: [PATCH] leds: make sure led->trigger is valid before calling trigger->activate
> 
> This is necessary if one wants to use the led->trigger field during
> trigger activation for a led (e.g. to set up the state of the led).
> No current drivers depend on this.

I seem to remember actively making the code work the way it does when I
originally wrote it, what I can't remember is why I did that :/.

Anyhow, I have no objections to the change and will probably queue it
for the next merge window, its post 2.6.26 material.

Cheers,

Richard



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/