Re: workqueue flush_work() patches

[Max Krasnyansky]

Oleg Nesterov wrote:
> On 06/27, Max Krasnyansky wrote:
> > I'm not sure if you guys saw my last email on this. So I'll restart the 
> > thread.
> > If you guys are ok with the summary I provided below I can put all 
> > Oleg's patches into some git tree, test them on my boxes and resend to 
> > Andrew.
>
> I'll re-send these flush_work() patches to Andrew on Sunday,
Excellent. Feel free to include
Acked-By: Max Krasnyansky <maxk@xxxxxxxxxxxx>

> > I was also going to go over the users of flush_queued_work() and 
> > convert them to cancel_work_sync() and/or flush_work().
>
> I think this would be very nice in any case.
>
> but I don't think flush_work() will find a lot of users...
Well, you've already found one (schedule_on_each_cpu()) there will 
probably be more. But I agree that flush is mostly used in cleanup 
procedures and therefor most users just need cancel_work_sync().

Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/