Re: [PATCH v4 6/6] Atmel MCI: Driver for Atmel on-chip MMCcontrollers

From: Pierre Ossman
Date: Sat Jun 28 2008 - 10:11:44 EST


On Sat, 28 Jun 2008 16:01:21 +0200
Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx> wrote:

>
> bytes_xfered is 0 if any block failed. If I understand correctly, this
> is good enough, but not optimal. I want to improve this later, but I
> might need some more feedback from the DMA engine subsystem (e.g.
> adding "actual" and "status" fields to the descriptor.)
>

That's good enough yes. The only incorrect value is reporting more than
was actually written as that would completely undermine any attempts of
keeping data integrity in upper layers.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature