Re: [patch 2.6.26-rc8] drivers/power: fix platform driverhotplug/coldplug

[Andrew Morton]

On Wed, 2 Jul 2008 00:13:14 -0700 David Brownell <david-b@xxxxxxxxxxx> wrote:

> From: Kay Sievers <kay.sievers@xxxxxxxx>
> 
> Since 43cc71eed1250755986da4c0f9898f9a635cb3bf

Linus chucks a wobbly if we quote bare SHA hashes at him.  I updated
the changelog appropriately.

>, the platform
> modalias is prefixed with "platform:". Add MODULE_ALIAS() to the
> hotpluggable "power" drivers drivers, to re-enable auto loading.
> 
> Signed-off-by: Kay Sievers <kay.sievers@xxxxxxxx>
> [ dbrownell@xxxxxxxxxxxxxxxxxxxxx: one was missing ]
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/power/ds2760_battery.c |    2 ++
>  drivers/power/pda_power.c      |    2 ++
>  2 files changed, 4 insertions(+)
> 
> --- a/drivers/power/ds2760_battery.c	2008-07-01 23:49:46.000000000 -0700
> +++ b/drivers/power/ds2760_battery.c	2008-07-01 23:51:48.000000000 -0700
> @@ -433,6 +433,8 @@ static int ds2760_battery_resume(struct 
>  
>  #endif /* CONFIG_PM */
>  
> +MODULE_ALIAS("platform:ds2760-battery");
> +
>  static struct platform_driver ds2760_battery_driver = {
>  	.driver = {
>  		.name = "ds2760-battery",
> --- a/drivers/power/pda_power.c	2008-07-02 00:10:18.000000000 -0700
> +++ b/drivers/power/pda_power.c	2008-07-02 00:10:36.000000000 -0700
> @@ -362,6 +362,8 @@ static int pda_power_resume(struct platf
>  #define pda_power_resume NULL
>  #endif /* CONFIG_PM */
>  
> +MODULE_ALIAS("platform:pda-power");
> +
>  static struct platform_driver pda_power_pdrv = {
>  	.driver = {
>  		.name = "pda-power",

Do we think this is needed in 2.6.26?

In 2.6.25.x?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/