Re: [PATCH] crypto/tcrypt.c fix resource leak
From: Herbert Xu
Date: Tue Jul 08 2008 - 04:23:11 EST
On Tue, Jul 08, 2008 at 05:24:14AM +1000, Darren Jenkins" wrote:
> G'day people,
>
> Coverity CID: 2306 & 2307 RESOURCE_LEAK
>
> In the second for loop in test_cipher(), data is allocated space with
> kzalloc() and is only ever freed in an error case.
> Looking at this loop, data is written to this memory but nothing seems
> to read from it.
> So here is a patch removing the allocation, I think this is the right
> fix.
>
> Only compile tested.
>
> ïSigned-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
Patch applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/