Re: [PATCH] drm_memory.h: remove double inclusion of linux/vmalloc.h

[Mark Asselstine]

On Sun, Jul 6, 2008 at 7:31 AM, Alexander Beregalov
<a.beregalov@xxxxxxxxx> wrote:
> From: Alexander Beregalov <a.beregalov@xxxxxxxxx>
>
> Remove double inclusion of linux/vmalloc.h
>
> drivers/char/drm/drm_memory.h |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> Signed-off-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
> ---
>
> diff --git a/drivers/char/drm/drm_memory.h b/drivers/char/drm/drm_memory.h
> index 63e425b..15af9b3 100644
> --- a/drivers/char/drm/drm_memory.h
> +++ b/drivers/char/drm/drm_memory.h
> @@ -44,8 +44,6 @@
>
>  #if __OS_HAS_AGP
>
> -#include <linux/vmalloc.h>
> -

Why remove this one and not the one at the top of the file? As well
this file has #include of drmP.h, yet drmP.h is the only file I can
find that includes drm_memory.h. Based on this I would think there is
some additional cleanup that can go on here.

Regards,
Mark Asselstine

>  #ifdef HAVE_PAGE_AGP
>  #include <asm/agp.h>
>  #else
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/