RE: [PATCH][resubmit] HP iLO driver

[Altobelli, David]

Pavel Machek wrote:
> It probably does configure passwords on the management processor, for
> example?
>
> And for that functionality, something like
>
> echo new_password > /sys/hpilo/admin/password
>
> would make sense, right? Except that your interface is more like "echo
> ^%TEWFSGFSDF^%EW&^Tadmin^*&S^F&*SDYF*&SDYF*&YE*Wnew_password(*
> &DF&S^DF*&DS^F*&S
>> /dev/hpilo/d0ccb0", right? (And except that you consider exact
> string to echo to change password "proprietary secret").
>
> We'd like to have the first interface, but unfortunately we do not
> know enough about hpilo to even ask for better interface.

Is the first interface really preferrable?  How does that extend
to commands that need to return data?  Do we want to manage 30 different
commands in the kernel?  New functionality would require kernel updates.

It seems much cleaner to keep the kernel interface simple and opaque
(ie read/write), and handle the details of the commands in user space.
>From my limited understanding, I thought that was a common goal here:
move what you can to userspace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/