Re: [PATCH 1/1] x86: Change _node_to_cpumask_ptr to return const ptr

From: Vegard Nossum
Date: Tue Jul 08 2008 - 17:52:23 EST


On Tue, Jul 8, 2008 at 11:35 PM, Mike Travis <travis@xxxxxxx> wrote:
> Subject: [PATCH 1/1] x86: Change _node_to_cpumask_ptr to return const ptr
>
> * Strengthen the return type for the _node_to_cpumask_ptr to be
> a const pointer. This adds compiler checking to insure that
> node_to_cpumask_map[] is not changed inadvertently.
>
> Applies to tip/master with the following patch applied:
>
> "[PATCH 1/1] x86: Add check for node passed to node_to_cpumask V3"
>
> Signed-off-by: Mike Travis <travis@xxxxxxx>
> ---

I can successfully cross-compile the asm-generic changes with a NUMA=y
config on ia64 without error or warning. So I guess, at long last, you
may put, FWIW:

Acked-by: Vegard Nossum <vegard.nossum@xxxxxxxxx>

Sorry for causing much trouble...


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/