Re: [patch] power, xen64: fix PM_SLEEP build dependencies (was:Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support)

[Ingo Molnar]

* Rafael J. Wysocki <rjw@xxxxxxx> wrote:

> > This combination actually doesn't make sense whatsoever.
> > 
> > PM_SLEEP depends (indirectly) on PM and the fact that it's possible 
> > to use a .config violating this dependency is a build system 
> > problem, really.
> 
> Your patch is correct, though. :-)

yes, that combination doesnt make sense in -git, but tip/xen64 tries the 
!PM && PM_SLEEP combination - see the patch below. What do you think 
about that patch?

I think Jeremy's patch makes sense, but no strong feelings. We can 
certainly map out these side-effects. (the fixes you've been Cc:-ed to 
should be roughly all that can happen i think.)

	Ingo

------------------->
commit 6fbbec428c8e7bb617da2e8a589af2e97bcf3bc4
Author: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date:   Tue Jul 8 15:07:08 2008 -0700

    suspend, xen: enable PM_SLEEP for CONFIG_XEN
    
    Xen save/restore requires PM_SLEEP to be set without requiring
    SUSPEND or HIBERNATION.
    
    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
    Cc: Stephen Tweedie <sct@xxxxxxxxxx>
    Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>
    Cc: Mark McLoughlin <markmc@xxxxxxxxxx>
    Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index b45da40..1436c47 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -82,7 +82,7 @@ config PM_SLEEP_SMP
 
 config PM_SLEEP
 	bool
-	depends on SUSPEND || HIBERNATION
+	depends on SUSPEND || HIBERNATION || XEN
 	default y
 
 config SUSPEND

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/