Re: [PATCH 02/34] AMD IOMMU: add header file for driver datastructures and defines

[Andrew Morton]

On Thu, 26 Jun 2008 21:27:38 +0200 Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> +/* helper macros */
> +#define LOW_U32(x) ((x) & ((1ULL << 32)-1))
> +#define HIGH_U32(x) (LOW_U32((x) >> 32))

Please avoid putting general-purpose helpers into private header files.

If we already have helper functions for this then use them.

If we don't have such helpers, let's write them, get them reviewed and put
them into kernel.h.

If we don't want these helpers in kernel.h then we don't want them in the
iommu driver either.

This cleanup work can be done separately from reviewing, testing amd
merging the IOMMU driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/