Re: [PATCH 04/34] AMD IOMMU: add data structures to manage theIOMMUs in the system

[Andrew Morton]

On Thu, 26 Jun 2008 21:27:40 +0200 Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> This patch adds the data structures which will contain the information read
> from the ACPI table.
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
> ---
>  arch/x86/kernel/amd_iommu_init.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
> index 6fce5ab..0ad8cf9 100644
> --- a/arch/x86/kernel/amd_iommu_init.c
> +++ b/arch/x86/kernel/amd_iommu_init.c
> @@ -99,3 +99,20 @@ struct ivmd_header {
>  	u64 range_length;
>  } __attribute__((packed));
>  
> +static int __initdata amd_iommu_disable;
> +
> +u16 amd_iommu_last_bdf;
> +struct list_head amd_iommu_unity_map;
> +unsigned amd_iommu_aperture_order = 26;
> +int amd_iommu_isolate;
> +
> +struct list_head amd_iommu_list;
> +struct dev_table_entry *amd_iommu_dev_table;
> +u16 *amd_iommu_alias_table;
> +struct amd_iommu **amd_iommu_rlookup_table;
> +struct protection_domain **amd_iommu_pd_table;
> +unsigned long *amd_iommu_pd_alloc_bitmap;
> +
> +static u32 dev_table_size;
> +static u32 alias_table_size;
> +static u32 rlookup_table_size;

hm, one would expect to see the header file which declares the globals in
the same patch as the .c file which defines them.  Whatever.

What locks the list_heads?  It would be good to add a code comment at the
definition site describing that locking.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/