Re: [PATCH 12/34] AMD IOMMU: add detect code for AMD IOMMU hardware

[Andrew Morton]

On Thu, 26 Jun 2008 21:27:48 +0200 Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> This patch adds the detection of AMD IOMMU hardware provided on information
> from ACPI provided by the BIOS.
> 
> ...
>
> +static int __init init_iommu_all(struct acpi_table_header *table)
> +{
> +	u8 *p = (u8 *)table, *end = (u8 *)table;
> +	struct ivhd_header *h;
> +	struct amd_iommu *iommu;
> +	int ret;
> +
> +	INIT_LIST_HEAD(&amd_iommu_list);

Initialisation of a global list_head should be unnecessary.  Just define
the list_head with LIST_HEAD() and do it at compile-time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/