Re: [PATCH] dsp56k: use request_firmware

From: Fredrik Noring
Date: Thu Jul 10 2008 - 04:08:56 EST


Hi David,

9 jul 2008 kl. 15.05 skrev David Woodhouse:
It is in fact identical. Disassembly with the tools found on sourceforge
was fun, since they have endianness bugs, don't recognise the 'JMP'
which was the first instruction, and need each 3-byte instruction in the
binary to be prefixed with a zero byte to make it 4 bytes. But after
sorting that out and going through it instruction by instruction, it
really does seem to match.

Heh. Amazing.

[ I think the code can be simplified: It currently copies itself to a high program memory location, but this is not necessary because DSP soft reset was never implemented (the reset would have been trapped by the code, in order to load a new program). The driver instead power- cycles the DSP every time a new program is loaded. ]

Thanks very much for digging it out.

No problem!

When you say 'GPL like the driver it came from', actually the driver
doesn't specify any version of the GPL but does refer to the top-level
COPYING file. So we'll take that to mean 'GPLv2 and not later', like the
majority of the kernel. OK?

OK with me.

Thanks,
Fredrik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/