Re: [PATCH] quota: Fix possible infinite loop in quota code

From: Jan Kara
Date: Thu Jul 10 2008 - 05:06:11 EST


On Wed 09-07-08 15:12:54, Andrew Morton wrote:
> On Wed, 9 Jul 2008 19:30:41 +0200 Jan Kara <jack@xxxxxxx> wrote:
>
> > When quota structure is going to be dropped and it is dirty, quota code
> > tries to write it. If the write fails for some reason (e. g. transaction
> > cannot be started because the journal is aborted), we try writing again
> > and again and again... Fix the problem by clearing the dirty bit even if
> > the write failed.
>
> What do you consider the priority is here? Needed in 2.6.26? Backport to
> 2.6.25.x? Merge into 2.6.27 with a backport to 2.6.26.x and 2.6.25.x?
>
> Lots of options ;)
Since nobody has really seen it in the wild, I don't think it's urgent.
The bug has been there for 5 years or so without notice... I'd just let it
be included in 2.6.26.x maybe 2.6.25.x and push into 2.6.27.

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/