Re: x86/pci: Broken build for X86_VISWS

From: Ingo Molnar
Date: Thu Jul 10 2008 - 06:39:01 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Robert Richter <robert.richter@xxxxxxx> wrote:
>
> > Ingo,
> >
> > during testing of my pci changes I observed a build error if X86_VISWS
> > is set:
> >
> > arch/x86/mach-visws/built-in.o: In function `machine_power_off':
> > (.text+0x48): undefined reference to `pci_bus0'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> >
> > The root cause is disabling PCI dependencies in change 1ac97018 that
> > disables compilation of x86/pci for VISWS though there are files in
> > needed to build. I am not sure if it is save to enable PCI for VISWS
> > to fix this.
> >
> > Could you take a look at this?
>
> well spotted. Does the patch below fix it for you?

there's another visws build bug related to generic-ipi - i fixed that in
tip/master.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/