Re: [PATCH] uio: uio_pdrv_genirq V2

[Uwe Kleine-König]

Hi,

Hans J. Koch wrote:
> > > +       ret = uio_register_device(&pdev->dev, priv->uioinfo);
> > > +       if (ret) {
> > > +               dev_err(&pdev->dev, "unable to register uio device\n");
> > > +               goto bad1;
> > > +       }
> > > +
> > > +       platform_set_drvdata(pdev, priv);
> > This should probably go before uio_register_device.  (Uups, this is an
> > issue for uio_pdrv, too.)
> 
> Yes, because uio_register_device will enable the irq, and you might
> arrive in the handler without having your platform data in place.
How do we want to fix that?  Should I sent a new version that also
includes the memory-leak fix and copyright specification?  Or another
incremental patch?

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/