Re: [Bug #11035] System hangs on 2.6.26-rc8

[Luiz Fernando N. Capitulino]

Em Thu, 10 Jul 2008 16:29:39 +0400
Roman Mindalev <lists@xxxxxxxxx> escreveu:

| Rafael J. Wysocki wrote:
| > This message has been generated automatically as a part of a report
| > of recent regressions.
| > 
| > The following bug entry is on the current list of known regressions
| > from 2.6.25.  Please verify if it still should be listed.
| > 
| > 
| > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11035
| > Subject		: System hangs on 2.6.26-rc8
| > Submitter	: Roman Mindalev <lists@xxxxxxxxx>
| > Date		: 2008-07-02 14:25 (5 days old)
| > References	: http://marc.info/?l=linux-kernel&m=121500871414995&w=4
| > 
| > 
| > 
| I have this problem with 2.6.25 too.
| Unfortunately, I can't check 2.6.24. With config from 2.6.26-rc8 I got
| error of compiling:
| 
|   LD      .tmp_vmlinux1
| kernel/built-in.o: In function `timespec_add_ns':
| /usr/src/kernels/linux-2.6.24/include/linux/time.h:179: undefined
| reference to `__umoddi3'

 [...]

 You're trying to compile with gcc 4.3, right? You can try the
attached fix or the following cherry-pick if you're compiling
from a git tree:

$ git cherry-pick 38332cb98772f5ea757e6486bed7ed0381cb5f98

 But I can't tell whether the compiler and/or the fix will
change the behaivor of the bug you're reporting.

-- 
Luiz Fernando N. Capitulino
commit 38332cb98772f5ea757e6486bed7ed0381cb5f98
Author: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
Date:   Tue Mar 4 14:59:54 2008 -0800

    time: prevent the loop in timespec_add_ns() from being optimised away
    
    Since some architectures don't support __udivdi3().
    
    Signed-off-by: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
    Cc: john stultz <johnstul@xxxxxxxxxx>
    Cc: Ingo Molnar <mingo@xxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

diff --git a/include/linux/time.h b/include/linux/time.h
index 2091a19..d32ef0a 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -174,6 +174,10 @@ static inline void timespec_add_ns(struct timespec *a, u64 ns)
 {
 	ns += a->tv_nsec;
 	while(unlikely(ns >= NSEC_PER_SEC)) {
+		/* The following asm() prevents the compiler from
+		 * optimising this loop into a modulo operation.  */
+		asm("" : "+r"(ns));
+
 		ns -= NSEC_PER_SEC;
 		a->tv_sec++;
 	}