Re: [PATCH 04/04] resource: add new IORESOURCE_CLK type

[Andrew Morton]

On Wed, 09 Jul 2008 20:55:02 +0900 Magnus Damm <magnus.damm@xxxxxxxxx> wrote:

> This patch rearranges the values of the IORESOURCE_TYPE_BITS from
> one bit per type to a 4-bit counter. Also, IORESOURCE_CLK is added.
> Not sure if it is better to start counting from 0 instead of 1.
> 

I don't believe this is an adequate changelog.  It contains the "what" but
not the "why".

Why did we switch from one-bit to four-bits?

Why did we add IORESOURCE_CLK?

The latter was convered in [0/n] a bit, but not at all clearly/fully.


> ---
> 
>  include/linux/ioport.h |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> --- 0003/include/linux/ioport.h
> +++ work/include/linux/ioport.h	2008-07-09 15:19:45.000000000 +0900
> @@ -37,8 +37,9 @@ struct resource_list {
>  #define IORESOURCE_TYPE_BITS	0x00000f00	/* Resource type */
>  #define IORESOURCE_IO		0x00000100
>  #define IORESOURCE_MEM		0x00000200
> -#define IORESOURCE_IRQ		0x00000400
> -#define IORESOURCE_DMA		0x00000800
> +#define IORESOURCE_IRQ		0x00000300
> +#define IORESOURCE_DMA		0x00000400
> +#define IORESOURCE_CLK		0x00000500
>  
>  #define IORESOURCE_PREFETCH	0x00001000	/* No side effects */
>  #define IORESOURCE_READONLY	0x00002000
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/