Re: [PATCH] Fix the fcpnp_driver declaration to only exist ifCONFIG_PNP=y

[Andrew Morton]

On Fri, 11 Jul 2008 15:36:48 +0100 David Howells <dhowells@xxxxxxxxxx> wrote:

> Fix the fcpnp_driver declaration to only exist if CONFIG_PNP=y as it's only
> accessed in that case.
> 
> The PNP=n variant was added by patch 30d55e71a81b1f5a8136f191dc9f4c21f18e77e6.
> 

Does this fix a build error or a warning or what?  A warning, I think.

> 
> diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c
> index c0b4db2..1925118 100644
> --- a/drivers/isdn/hisax/hisax_fcpcipnp.c
> +++ b/drivers/isdn/hisax/hisax_fcpcipnp.c
> @@ -974,8 +974,6 @@ static struct pnp_driver fcpnp_driver = {
>  	.remove		= __devexit_p(fcpnp_remove),
>  	.id_table	= fcpnp_ids,
>  };
> -#else
> -static struct pnp_driver fcpnp_driver;
>  #endif
>  
>  static void __devexit fcpci_remove(struct pci_dev *pdev)

I have to run around and work out of the fix is needed in 2.6.25
or 2.6.26 or linux-next.  Telling me this is always appreciated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/