Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic

From: Jeremy Fitzhardinge
Date: Sun Jul 13 2008 - 13:46:52 EST


Jakub W. Jozwicki wrote:

Sorry, this was for -rt only.

[ 17.012011] BUG: sleeping function called from invalid context IRQ-14(5732) at arch/x86/mm/highmem_32.c:8
[ 17.012011] in_atomic():0 [00000000], irqs_disabled():1
[ 17.012011] Pid: 5732, comm: IRQ-14 Not tainted 2.6.25.10-rtXXX #11
[ 17.012011] [<c0120fc4>] __might_sleep+0xf1/0xf8
[ 17.012011] [<c011c035>] kmap+0x47/0x5a

The subject says kmap_atomic, but this is kmap. It definitely makes no sense to call kmap in an IRQ, regardless of the locking. There seems to be a larger structural problem here.

[ 17.012011] [<c033e728>] ata_hsm_move+0x3d7/0x657
[ 17.012011] [<c0342fd6>] ata_interrupt+0x14e/0x1cb
[ 17.012011] [<c015c72c>] handle_IRQ_event+0x4e/0xd1
[ 17.012011] [<c015d266>] do_irqd+0x126/0x224
[ 17.012011] [<c015d140>] ? do_irqd+0x0/0x224
[ 17.012011] [<c013ae9d>] kthread+0x3b/0x62
[ 17.012011] [<c013ae62>] ? kthread+0x0/0x62
[ 17.012011] [<c0108287>] kernel_thread_helper+0x7/0x10
[ 17.012011] =======================

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/