Re: [lm-sensors] [RFC] (almost) booting allyesconfig -- please don'tpoke super-io without request_region

[Hans de Goede]

David Hubbard wrote:
> Hi Hans, Milton, Jean,
>
> On Sun, Jul 13, 2008 at 12:31 AM, Hans de Goede <j.w.r.degoede@xxxxxx> wrote:
> > Jean Delvare wrote:
> > > On Fri, 11 Jul 2008 09:27:26 +0200, Hans de Goede wrote:
> > > > Jean Delvare wrote:
> > > > > Hi Hans, hi Milton,
> > > > <snip>
> > > >
> > > > > > One could make a superio driver, and create sub-devices for the IR,
> > > > > > I2C, floppy, parallel, etc
> > > > > > nodes.
> > > > > There have been proposals to do this, and this would indeed be a very
> > > > > good idea, but unfortunately nobody took the time to implement this
> > > > > properly, push it upstream and volunteer to maintain it. The problem is
> > > > > that you don't need just a "driver", but a new subsystem, that needs to
> > > > > be designed and maintained.
> > > > Well, I believe there have been some lightweight superio locking coordinator
> > > > patches been floating around on the lm_sensors list, and I have reviewed them
> > > > and then a new version was done with my issues fixed.
> > > >
> > > > I kinda liked the proposed solution there, it was quite simple, moved all the
> > > > generic superio stuff into generic superio code, and added locking for super io
> > > > access from multiple drivers, what ever happened to those patches?
> > > As far as I know, nothing, and this is the problem. Somebody needs to
> > > step up and call him/herself the maintainer of the new code, and push
> > > it upstream and convert all the drivers (hwmon, watchdog, parallel
> > > port...) to make use of it. And I am not the one to do this, I am busy
> > > enough as is with i2c and hwmon.
> > Ok, I've mailed Jim Cromie, the author of the superio access patches
> > from end 2007 and told him we're still interested in this and asked him
> > if he is willing to drive this forward.
>
> I propose writing a subsystem driver. (Is that properly called "The
> SuperIO Bus Driver"?) If no one thinks it's a really bad idea I will
> put together some code and submit it for review, and maintain it.
>
> Some hwmon chips have odd / unique probe sequences. IMHO this is where
> the design needs to be inspected. One of those is the w83627ehf, which
> Jean and Hans are familiar enough with to check my work.
>
> Thoughts?

I'm afraid that making this a "bus" will be a bit overkill. Jim's patches are 
quite simple and seem todo the job.

Also keep in mind that most users will be platform devices which just want to 
use the superio registers to find out the baseaddress of their logical device, 
a whole bus seems overkill for this, would the hwmon driver then need to be a 
superio_driver (as well as an platform_driver) or can the bus be queried / used
without having to be a bustype-driver?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/