Re: [PATCH] qla1280: use request_firmware

[Jes Sorensen]

Jaswinder Singh wrote:
> We have not changed the data.
> We are passing risc_code01 data by using request_firmware when required.
>
> If you found some problem in the code, Please let me know.

My issue was not about changing the format of the data, but about it
being forced into userland, ie. requiring an initrd. After speaking to
Woodhouse over irc, I have learned that with the new firmware
infrastructure this is optional and one can still link the firmware into
the kernel.

Given that the previous firmware moving patches have always been about
getting firmware out of the kernel due to certain distro's being silly
about it, this wasn't actually obvious. If your patch description had
been a little more detailed and explained that it didn't require
firmware to go into userland it would have been easier for someone who
hasn't been following the previous thread on the subject.

So, I don't have any objections to this patch as long as the new
firmware interface continues to allow me to link this into the kernel.

Regards,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/