Re: [git pull] core/stacktrace changes for v2.6.27

[Ingo Molnar]

* Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> Hi Ingo,
> 
> On Mon, 14 Jul 2008 16:44:20 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > Please pull the latest core/stacktrace git tree from:
> > 
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core/stacktrace
> 
> This presumably needs the patch I posted today against linux-next that 
> fixes the powerpc allmodconfig build.

hm - but you sent that against the generic-ipi tree :-)

but i agree - the patch is below, Linus please apply.

	Ingo

---------------->
commit 7798ed0f57b4d137e660fbf5be1e1528e40f89ac
Author: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date:   Mon Jul 14 19:55:03 2008 +1000

    generic-ipi: powerpc/generic-ipi tree build failure
    
    Today's linux-next build (powerpc allmodconfig) failed like this:
    
    ERROR: ".save_stack_trace" [tests/backtracetest.ko] undefined!
    
    But save_stack_trace is exported in arch/powerpc/kernel/stacktrace.c
    
    I couldn't figure it out until I noticed these earlier warnings:
    
    arch/powerpc/kernel/stacktrace.c:47: warning: data definition has no type or storage class
    arch/powerpc/kernel/stacktrace.c:47: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
    arch/powerpc/kernel/stacktrace.c:47: warning: parameter names (without types) in function declaration
    
    I applied the patch below.
    
    Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
    Cc: Paul Mackerras <paulus@xxxxxxxxx>
    Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
    Cc: <linuxppc-dev@xxxxxxxxxx>
    Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
 arch/powerpc/kernel/stacktrace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index 9861f17..3cf0d94 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -12,6 +12,7 @@
 
 #include <linux/sched.h>
 #include <linux/stacktrace.h>
+#include <linux/module.h>
 #include <asm/ptrace.h>
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/