[PATCH 3/4] BUG_ON on kernel misbehavior on A100U2W driver

From: Mikulas Patocka
Date: Tue Jul 15 2008 - 10:14:28 EST


With broken Sparc64 IOMMU accounting, the kernel submits larger requests then allowed. Better to crash on BUG than corrupt memory. This needs to be fixed in sparc64 code.

For description of the crashes, see: http://www.uwsg.indiana.edu/hypermail/linux/kernel/0807.1/1465.html

Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
---
drivers/scsi/a100u2w.c | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6.26-devel/drivers/scsi/a100u2w.c
===================================================================
--- linux-2.6.26-devel.orig/drivers/scsi/a100u2w.c 2008-07-14 20:03:43.000000000 +0200
+++ linux-2.6.26-devel/drivers/scsi/a100u2w.c 2008-07-15 00:46:02.000000000 +0200
@@ -866,6 +866,7 @@ static void inia100_build_scb(struct orc

count_sg = scsi_dma_map(cmd);
BUG_ON(count_sg < 0);
+ BUG_ON(count_sg > TOTAL_SG_ENTRY);

/* Build the scatter gather lists */
if (count_sg) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/