Re: [PATCH] x86: traps and do_traps under one hood

[David Woodhouse]

On Tue, 2008-07-15 at 16:22 +0530, Jaswinder Singh wrote:
> Declaring x86 traps under one hood.
> Declaring x86 do_traps before defining them.

> arch/x86/kernel/traps_32.c                |   20 ---------
> arch/x86/kernel/traps_64.c                |   21 ----------
> include/asm-x86/mach-default/mach_traps.h |   62 +++++++++++++++++++++++++++++

You put these back in mach-default/mach_traps.h but does that cover all
possibilities? What about other machine types?

Looking at the ifdefs you introduced in that header, it seems there's
more scope for unification here (although it makes sense for that to
come later).

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/