Re: [PATCH 14/14] ACPI: Provide /sys/devices/system/cpu/cpuN/deconfigure

[Andi Kleen]

Alex Chiang wrote:
> Provide a new sysfs interface for CPU deconfiguration.
>
> Since no vendors can agree on terminology for related but slightly
> different features, provide a method for a platform to implement
> its own version of what it thinks 'deconfiguring' a CPU might be.
>
> Provide an HP-specific CPU deconfiguration implementation.

Why are you ccing this to linux-arch? Dropped.

What is the standard status of these new SCFG and ECFG tables? Have they
been submitted for possible inclusion in ACPI? And is there a spec
available? I can't say I'm really thrilled with having HP specific
support in there.

It would be better at least if you could reserve the table names and 
then drop the HP DMI check. This is needed anyways, otherwise the 
standard at some point could add different ECFG/SCFG tables.

> + * After echo'ing 0 or 1 into deconfigure, cat'ing the file will
> + * return the next boot's status. However, the CPU will not actually
> + * be deconfigured until the next boot.

Now that seems like weird semantics for a public fixed API. What happens
when some other vendor adds hot deconfiguration?

My feeling is that this seems to be overly specific to your BIOS
and might better belong into some separate management tool. At least
until we can define a nice general API for this with clear semantics. 
For what systems is this anyways?

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/