Re: [SUGGESTION]: drop virtual merge accounting in I/O requests

[David Miller]

From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Date: Tue, 15 Jul 2008 18:32:37 -0400 (EDT)

> On Mon, 14 Jul 2008, David Miller wrote:
> 
> > From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> > Date: Mon, 14 Jul 2008 19:16:17 -0400 (EDT)
> > 
> > > So the question is: to reduce number of requests by 12% on an outdated 
> > > SCSI card, it is sensible to maintain complicated merge accounting logic 
> > > in the core block layer? To me, it doesn't seem sensible.
> > 
> > Rip out the code if you like, then.  I really don't have time to
> > work on this myself.  So if you do, by all means do whatever
> > you think is appropriate.
> 
> So add signed-off line and forward it to Linus.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>

I said remove code, not turn if off.  I guess you didn't like
that option even though you seem heavily convinced that it buys
us essentially nothing, and I'm even starting to agree with you.

If the VMERGE code is going to stay, and it's a bug or a limitation in
the sparc64 IOMMU code, I'd rather that get fixed.

I have FUJITA's excellent analysis of the sparc64 specific IOMMU issue
in my inbox and I intend to have a look at it when I get a chance.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/