Re: [PATCH 2.6.26] isofs: fix minor filesystem corruption, take 2

From: Pekka Enberg
Date: Wed Jul 16 2008 - 04:23:54 EST


Hi Adam,

On Tue, 2008-07-15 at 22:18 -1000, Adam Greenblatt wrote:
> Some iso9660 images contain files with rockridge data that is either
> incorrect or
> incompletely parsed. Prior to commit
> f2966632a134e865db3c819346a1dc7d96e05309,
> (included with kernel 2.6.13) the kernel ignored the rockridge data for
> these files,
> while still allowing the files to be accessed under their non-rockridge
> names. That
> commit inadvertently changed things so that files with invalid rockridge
> data could
> not be accessed at all. (I ran across the problem when comparing some
> old CDs with
> hard disk copies I had made long ago under kernel 2.4: a few of the
> files on the hard
> disk copies were no longer visible on the CDs.)
>
> This change reverts to the pre-2.6.13 behavior.
>
> Signed-off-by: Adam Greenblatt <adam.greenblatt@xxxxxxxxx>
> ---
> Pekka Enberg correctly pointed out that there was a similar change made to
> parse_rock_ridge_inode_internal() that should also be reverted. Please
> ignore
> my previous patch, and use this patch instead. Thanks Pekka!

Looks good to me.

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/