Re: [PATCH] cpu hotplug, sched: Introduce cpu_active_map andredo sched domain managment (take 2)

[Gregory Haskins]

>>> On Tue, Jul 15, 2008 at  7:43 AM, in message
<1216122229-4865-1-git-send-email-maxk@xxxxxxxxxxxx>, Max Krasnyansky
<maxk@xxxxxxxxxxxx> wrote: 

> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index 47ceac9..5166080 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -922,6 +922,13 @@ static int find_lowest_rq(struct task_struct *task)
>  		return -1; /* No targets found */
>  
>  	/*
> +	 * Only consider CPUs that are usable for migration.
> +	 * I guess we might want to change cpupri_find() to ignore those
> +	 * in the first place.
> +	 */ 
> +	cpus_and(*lowest_mask, *lowest_mask, cpu_active_map);
> +
> +	/*
>  	 * At this point we have built a mask of cpus representing the
>  	 * lowest priority tasks in the system.  Now we want to elect
>  	 * the best one based on our affinity and topology.

Hi Max,
  Its still early in the morning, and I havent had my coffee yet, so what I am about to
say may be totally bogus ;)

..but, I am not sure we need to do this mask here.  If the hotcpu_notifiier is still
running (and it appears that it is) the runqueue that is taken offline will be removed
from cpupri as well.

Or perhaps I am misunderstanding the intention of "active" verses "online".  If I
understand correctly, active and online mean more or less the same thing, but
splitting it out like this allows us  to skip rebuilding the domains on every hotplug.
Is that correct?

Assuming that the above is true, and assuming that the hotcpu_notifier is
still invoked when the online status changes, cpupri will be properly updated
to exclude the offline core.  That will save an extra cpus_and (which the big-iron
guys will be happy about ;)

Regards,
-Greg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/