Re: [PATCH] stopmachine: add stopmachine_timeout v2
From: Hidetoshi Seto
Date: Wed Jul 16 2008 - 23:41:06 EST
Jeremy Fitzhardinge wrote:
> Hidetoshi Seto wrote:
>> +#ifdef CONFIG_STOP_MACHINE
>> +extern unsigned long stopmachine_timeout;
>> +#endif
>
> No externs in C files. Put it in an appropriate header.
sysctl.c already has many externs... but I can fix at least
the above.
> I'll do a proper review soon.
Is it better to postpone v4 until your comment comes?
Thanks,
H.Seto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/