RE: [PATCH 00/11] fsl_usb2_udc: A number of bug fixes and cleanups.

From: Li Yang
Date: Thu Jul 17 2008 - 05:43:54 EST


> -----Original Message-----
> From: Will Newton [mailto:will.newton@xxxxxxxxxx]
> Sent: Tuesday, July 15, 2008 11:25 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx; Li Yang; Jiang Bo;
> gregkh@xxxxxxx; Will Newton
> Subject: [PATCH 00/11] fsl_usb2_udc: A number of bug fixes
> and cleanups.
>
> From: Will Newton <will.newton@xxxxxxxxx>
>
> Hi,
>
> These patches fix a couple of small bugs and cleanup parts of
> the fsl_usb2_udc USB gadget driver. I've split them up quite
> finely for ease of reviewing and to separate functional
> changes. Any comments would be appreciated.
>
> I would also appreciate it if someone with real Freescale
> hardware could test these changes, I'm testing this driver
> with a different SoC containing the same TDI/ARC/ChipIdea IP block.

Thanks for the patches. Looks like they are ok, but I still need to
test them later.

What's the SoC you have tested with the driver? Maybe you could also
update the Kconfig for that.

- Leo
>
> Thanks,
>
> Will Newton (11):
> fsl_usb2_udc: Make dr_ep_setup function static.
> fsl_usb2_udc: Remove check for udc == NULL in dr_controller_setup.
> fsl_usb2_udc: Fix some sparse warnings and remove redundant code.
> fsl_usb2_udc: Clean up whitespace in errors and warnings.
> fsl_usb2_udc: Clean up whitespace in /proc debugging output.
> fsl_usb2_udc: Initialize spinlock earlier.
> fsl_usb2_udc: Rename the arguments of the fsl_writel macro.
> fsl_usb2_udc: Uninline udc_reset_ep_queue.
> fsl_usb2_udc: Make fsl_queue_td return type void.
> fsl_usb2_udc: Add a wmb before priming endpoint.
> fsl_usb2_udc: Fix oops on probe failure.
>
> drivers/usb/gadget/fsl_usb2_udc.c | 176
> ++++++++++++++++--------------------
> drivers/usb/gadget/fsl_usb2_udc.h | 21 +----
> 2 files changed, 80 insertions(+), 117 deletions(-)
>
> -
> This message is subject to Imagination Technologies' e-mail
> terms: http://www.imgtec.com/e-mail.htm
> -
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/