Re: [PATCH v3] leds: implement OpenFirmare GPIO LED driver

[Nate Case]

On Tue, 2008-07-15 at 19:19 +0400, Anton Vorontsov wrote:
> +       led->cdev.name = of_get_property(np, "label", NULL);
> +       if (!led->cdev.name)
> +               led->cdev.name = dev_name(&ofdev->dev);

How about also supporting a "trigger" property which would set
cdev.default_trigger in the same manner?  It would be useful for boards
to be able to specify this in the device tree (e.g., if a certain LED is
meant to be used as a "heartbeat").

-- 
Nate Case <ncase@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/