Re: [PATCH 1/2] nfs: nfs4xdr use C99 array initializers

[Harvey Harrison]

On Fri, 2008-07-18 at 14:01 -0400, J. Bruce Fields wrote:
> On Thu, Jul 17, 2008 at 09:33:03PM -0700, Harvey Harrison wrote:
> > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> 
> OK, thanks.  But I'd rather just skip the macro:
> 
> > +#define NFSD4_DEC_OP(idx, op)	[(idx)] = (nfsd4_dec)(op)
> > -	[OP_ACCESS]		(nfsd4_dec)nfsd4_decode_access,
> > -	[OP_CLOSE]		(nfsd4_dec)nfsd4_decode_close,
> > -	[OP_COMMIT]		(nfsd4_dec)nfsd4_decode_commit,
> > -	[OP_CREATE]		(nfsd4_dec)nfsd4_decode_create,
> > -	[OP_DELEGPURGE]		(nfsd4_dec)nfsd4_decode_notsupp,
> ...
> > +	NFSD4_DEC_OP(OP_ACCESS, nfsd4_decode_access),
> > +	NFSD4_DEC_OP(OP_CLOSE, nfsd4_decode_close),
> > +	NFSD4_DEC_OP(OP_COMMIT, nfsd4_decode_commit),
> > +	NFSD4_DEC_OP(OP_CREATE, nfsd4_decode_create),
> > +	NFSD4_DEC_OP(OP_DELEGPURGE, nfsd4_decode_notsupp),
> 
> and just add equals signs, if there's no substantial objection.
> 

None here.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/