Re: [PATCH] Introducing asm/syscalls.h

[Ralf Baechle]

On Sun, Jul 20, 2008 at 02:39:00PM +0530, Jaswinder Singh wrote:
> From: Jaswinder Singh <jaswinder@xxxxxxxxxxxxx>
> Date: Sun, 20 Jul 2008 14:39:00 +0530
> To: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>,
> 	David Woodhouse <dwmw2@xxxxxxxxxxxxx>, rth@xxxxxxxxxxx,
> 	rmk@xxxxxxxxxxxxxxxx, hskinnemoen@xxxxxxxxx, cooloney@xxxxxxxxxx,
> 	starvik@xxxxxxxx, dhowells@xxxxxxxxxx, ysato@xxxxxxxxxxxxxxxxxxxx,
> 	tony.luck@xxxxxxxxx, takata@xxxxxxxxxxxxxx, geert@xxxxxxxxxxxxxx,
> 	ralf@xxxxxxxxxxxxxx, dhowells@xxxxxxxxxx, matthew@xxxxxx,
> 	schwidefsky@xxxxxxxxxx, lethal@xxxxxxxxxxxx, chris@xxxxxxxxxx
> Subject: [PATCH] Introducing asm/syscalls.h
> Content-Type: text/plain
> 
> 
> Declaring arch-dependent syscalls for all architectures
> Beneficial for kernel and userspace
> 
> Signed-off-by: Jaswinder Singh <jaswinder@xxxxxxxxxxxxx>

You write beneficial for userspace - but don't add <asm/syscall.h> to
include/asm-generic/Kbuild.asm.  Fortunately.  I doubt there is any good
reason for userspace to know about kernel prototypes.  For configurations
where userspace and kernel API differ - think 32-bit code running on a
64-bit kernel or similar - that would be a receipe for disaster.

Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/