Re: [GIT]: Networking

From: Alexey Dobriyan
Date: Mon Jul 21 2008 - 07:59:47 EST


On Sun, Jul 20, 2008 at 10:11:06PM -0700, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Sun, 20 Jul 2008 19:48:56 -0700 (PDT)
>
> > From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> > Date: Mon, 21 Jul 2008 06:40:56 +0400
> >
> > > OK, the problem is really this buglet:
> > >
> > > BUG_ON(q == &noop_qdisc);
> > > __netif_schedule
> > > netif_tx_wake_queue
> > > netif_wake_queue
> > > atl1_check_link
> > > atl1_up or atlx_link_chg_task
> > > run_workqueue
> >
> > Thanks for the backtrace I'll work on fixing this.
>
> [ Jeff and co., this is basically the kind of patch I want
> to see eventually for the Intel drivers too... ]
>
> Alexey, please try this patch:
>
> atl1: Do not wake queue before queue has been started.

Patch helps and networking is back with and without using netconsole,
thank you!

Also wan to say, 8139too driver survived multiqueue TX changes fine.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/