Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest.

[Stephen Rothwell]

Hi Rusty,

On Tue, 22 Jul 2008 14:31:58 +1000 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
> +++ b/include/asm-x86/page.h	Tue Jul 22 14:09:33 2008 +1000
> @@ -144,6 +144,18 @@ static inline pteval_t native_pte_val(pt
>  	return pte.pte;
>  }
>  
> +/* This belongs in pgtable.h, but our includes are too much of a mess. */
> +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
> +#define PTE_FLAGS	_AC(0x8000000000000FFF, ULL)

Just a small point:  You don't actually need the _AC() because this is
already in a #ifndef __ASSEMBLY__ section of the file.  But better safe
than sorry, I guess.  :-)

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature