Re: [git pull] x86: declaration fixes

[Jaswinder Singh]

Hello Ingo,

On Mon, 2008-07-21 at 20:04 +0200, Ingo Molnar wrote:
> * Jaswinder Singh <jaswinder@xxxxxxxxxxxxx> wrote:
> 

> another thing:
> 
> --- a/include/asm-x86/signal.h
> +++ b/include/asm-x86/signal.h
> 
> +void do_notify_resume(struct pt_regs *, void *, __u32);
> +
> 
> please add "extern" to each such prototype declaration. (the same is 
> true for a handful of other prototypes you've added - please re-review 
> and fix them)
> 

I was trying to follow other functions declaration in the file.

function declaration without extern :-

http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=f740a1e1bbee2ce8a0b1b97361771db40afc37d2
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=b7b5113220da95eaa8b75ebd5bbd5278eed122e5

function declaration with extern :-

http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=8cac4294a5e9b036c30d30e2e894e74201ee1c6b
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=e7d3d48dbf3e517e2e827a2adc6a2f861b16e6a6
http://git.infradead.org/users/jaswinder/linux-2.6-tip.git?a=commitdiff;h=feb49274338051ddf11d16f67b08ee6cafb32dbf

But you are emphasizing to use extern for all function declarations.

With current gcc, I think using extern with function declaration is :-
1. Wastage of time
2. Wastage of energy
3. Increase file size with 7 bytes for each extern.

If there is any secret behind using extern in kernel header files.
Please let me know.

Thank you,

Jaswinder Singh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/