Re: [Patch] um: fix a build error

[Alan Cox]

> Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
> 
> --- linux-2.6/arch/um/drivers/line.c.orig	2008-07-22 12:06:17.000000000 +0200
> +++ linux-2.6/arch/um/drivers/line.c	2008-07-22 12:06:49.000000000 +0200
> @@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
>  	if (tty == NULL)
>  		return IRQ_NONE;
>  
> -	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
> -	   (tty->ldisc.write_wakeup != NULL))
> -		(tty->ldisc.write_wakeup)(tty);
> -
> +	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
> +		tty_wakeup(tty);

Sorry I should have been clearer - you don't want the test_bit either.

Acked-by: Alan Cox <alan@xxxxxxxxxx>

however as it is still right but you can stick my Ack on a version
without the if too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/